Bazaar

Bazaar

 




Wiki Tools

  • Find Page
  • Recent Changes
  • Page History
  • Attachments

Differences between revisions 1 and 2
Revision 1 as of 2006-11-10 09:30:17
Size: 1755
Comment: new spec
Revision 2 as of 2006-11-12 14:27:25
Size: 1851
Comment: draft
Deletions are marked like this. Additions are marked like this.
Line 12: Line 12:
## This should cover the _why_: why is this change being proposed, what justifies it, where we see this justified.

== Further Details ==

## In place of Description of Issue here, add your own title that provides a description of the issue, or intended funcionality, or proposed change. You can have subsections that better describe specific parts of the issue; you can also include here subsections like the following:

=== Assumptions ===
Bundles are now the preferred format to provide patches for reviewing purposes (see PQM and Bundle-Buggy for more details on this). bzr-gtk/Olive doesn't have support for bundles as of now.
Line 22: Line 16:
## It is important that the description section covers the functionality-related aspects (the "what") of the change. Providing rationale (the "why") is always a plus.  * Thomas finds a bug in Olive while he is using it. He has the time to correct that issue, and wants to send his modifications back to the maintainers, but currently there is no such feature in Olive, so he has to do it in a Terminal.
Line 26: Line 20:
## This section should describe a plan of action (the "how") to implement the changes discussed. Could include subsections like:
Line 30: Line 22:
## Should cover changes required to the UI, or specific UI that is required to implement this We need at least two new dialogs. One for creating and one for applying a bundle.

==== Dialog: Create bundle ====

This window would present the user the bundle itself (output of 'bzr bundle') in a textview. It should have two buttons: "Save to File" and "Copy to Clipboard". We could also add an option to generate a bundle for any chosen revisions.

==== Dialog: Apply bundle ====

This dialog would have the same textview, but blank as default. The two buttons here: "Open File" and "Paste from Clipoard".
Line 34: Line 34:
## Code changes should include an overview of what needs to change, and in some cases even the specific details.

=== Schema Changes ===

=== Data Migration ===
This feature would not affect the current codebase except from connecting the appropriate signals and inserting the various menu entries into the glade file.

Summary

We need to extend bzr-gtk's and Olive's capabilities to support bundles. This specification should cover both applying and creating a bundle.

Rationale

Bundles are now the preferred format to provide patches for reviewing purposes (see PQM and Bundle-Buggy for more details on this). bzr-gtk/Olive doesn't have support for bundles as of now.

Use Cases

  • Thomas finds a bug in Olive while he is using it. He has the time to correct that issue, and wants to send his modifications back to the maintainers, but currently there is no such feature in Olive, so he has to do it in a Terminal.

Implementation

UI Changes

We need at least two new dialogs. One for creating and one for applying a bundle.

Dialog: Create bundle

This window would present the user the bundle itself (output of 'bzr bundle') in a textview. It should have two buttons: "Save to File" and "Copy to Clipboard". We could also add an option to generate a bundle for any chosen revisions.

Dialog: Apply bundle

This dialog would have the same textview, but blank as default. The two buttons here: "Open File" and "Paste from Clipoard".

Code Changes

This feature would not affect the current codebase except from connecting the appropriate signals and inserting the various menu entries into the glade file.

Discussion

Unresolved Issues

Questions and Answers

CategorySpecification